Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Settings layout #999

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Admin Settings layout #999

merged 1 commit into from
Jan 6, 2025

Conversation

SteveMicroNova
Copy link
Contributor

@SteveMicroNova SteveMicroNova commented Nov 19, 2024 •
edited
Loading

What does this change intend to accomplish?

Indents subsections to make it more obvious that they are part of a given subheader, align buttons and textboxes, get rid of hoverover tooltips and add them to the top of settings subsections

Closes #998

Before:
image

After:
image

Checklist

  • Have you tested your changes and ensured they work?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass linting & tests? You can test on localhost using ./scripts/test
  • If this is a UI change, have you tested it across multiple browser platforms on both desktop and mobile?

rtertiaer
rtertiaer suggested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@rtertiaer rtertiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while you're at it, can you align the textbox elements so they don't look haphazard?

@rtertiaer
Copy link
Contributor

imo, tooltips like this are not good design. they are less accessible than the alternative of just describing the feature below its heading, and still aren't actually obvious, even with your svg.

@SteveMicroNova SteveMicroNova changed the title Format Admin Settings Admin Settings layout Dec 6, 2024
@SteveMicroNova
Copy link
Contributor Author

Marking this as "Not quite ready yet" due to this funny bug

Recording.2024-12-06.154824.mp4

@linknum23 linknum23 self-requested a review December 9, 2024 16:03
@SteveMicroNova
Copy link
Contributor Author

I have a few more CSS issues in this PR to iron out before it is ready for approval; the images are still valid means of judging the end product but the buttons seem to shrink after getting the loading spinner and success text

@SteveMicroNova
Copy link
Contributor Author

Problems solved, ready for review

@SteveMicroNova SteveMicroNova force-pushed the AdminSettingsLayout branch 3 times, most recently from 5aca651 to 477bd3f Compare December 9, 2024 21:48
@SteveMicroNova SteveMicroNova mentioned this pull request Dec 20, 2024
Closed
klay2000
klay2000 requested changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@klay2000 klay2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this looks better and the changes are fine at a glance code wise, I would just like the field descriptions to be a little more precise. I'll look at the code more closely once these are updated.

amplipi/updater/static/index.html Outdated Show resolved Hide resolved
amplipi/updater/static/index.html Outdated Show resolved Hide resolved
@SteveMicroNova
Add info cards, style overrides to admin settings tab of updater
7540074 
Update admin setting description wording

Reword description
@SteveMicroNova SteveMicroNova merged commit 770c469 into main Jan 6, 2025
3 checks passed
@SteveMicroNova SteveMicroNova deleted the AdminSettingsLayout branch January 6, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klay2000 klay2000 klay2000 approved these changes

@LegendaryMichael LegendaryMichael Awaiting requested review from LegendaryMichael

@rtertiaer rtertiaer Awaiting requested review from rtertiaer

@linknum23 linknum23 Awaiting requested review from linknum23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Format Admin Settings tooltip
3 participants
@SteveMicroNova @rtertiaer @klay2000